Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more/less in grids #2184

Closed
wants to merge 1 commit into from
Closed

Show more/less in grids #2184

wants to merge 1 commit into from
+35 −9

Conversation

Ankit-Singla
Copy link

@Ankit-Singla Ankit-Singla commented Jan 31, 2018 •
edited by jywarren
Loading

Fixes #2150

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@Ankit-Singla Ankit-Singla changed the title Show more/less Show more/less ( Fixes #2150 ) Jan 31, 2018
@PublicLabBot
Copy link

PublicLabBot commented Jan 31, 2018 •
edited
Loading

10 Errors
🚫 There was a test failure at: Failure: test_about_ability_of_power_tags_to_exclude_tags_like_activities:foo!foo1 [/app/test/unit/node_shared_test.rb:157]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_about_ability_of_power_tags_to_exclude_tags_like_notes:test!awesome [/app/test/unit/node_shared_test.rb:125]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_about_ability_of_power_tags_to_exclude_tags_like_questions:foo!answered [/app/test/unit/node_shared_test.rb:145]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_about_ability_of_power_tags_to_exclude_tags_like_questions:foo!foo1 [/app/test/unit/node_shared_test.rb:135]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_about_ability_of_power_tags_to_exclude_tags_like_upgrades:foo!foo1 [/app/test/unit/node_shared_test.rb:166]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_that_NodeShared_can_be_used_to_convert_doubled_short_codes_like_[notes:activity:spectrometer]into_tables_which_list_notes_with_the_tagactivity:spectrometer(Minitest::Result) [/app/test/unit/node_shared_test.rb:25]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_that_NodeShared_can_be_used_to_convert_short_codes_like_[activities:foo]_into_tables_which_list_activity_notes(Minitest::Result) [/app/test/unit/node_shared_test.rb:47]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_that_NodeShared_can_be_used_to_convert_short_codes_like_[notes:foo]_into_tables_which_list_notes(Minitest::Result) [/app/test/unit/node_shared_test.rb:10]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_that_NodeShared_can_be_used_to_convert_short_codes_like_[questions:foo]_into_tables_which_list_questions(Minitest::Result) [/app/test/unit/node_shared_test.rb:35]: Expected: 5 Actual: 4
🚫 There was a test failure at: Failure: test_that_NodeShared_can_be_used_to_convert_short_codes_like_[upgrades:latest]_into_tables_which_list_upgrade_notes(Minitest::Result) [/app/test/unit/node_shared_test.rb:57]: Expected: 5 Actual: 4
3 Messages
📖 @Ankit-Singla Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@SidharthBansal
Copy link
Member

Please remove the user validation commits.

@SidharthBansal SidharthBansal mentioned this pull request Jan 31, 2018
Closed
3 tasks
@Ankit-Singla
Copy link
Author

@SidharthBansal I have made the required changes as you had asked. The PR is clean, with a single commit from a uniquely-named-feature-branch. Please review the PR.

@jywarren jywarren changed the title Show more/less ( Fixes #2150 ) Show more/less in grids Mar 21, 2018
@jywarren
Copy link
Member

jywarren commented Jun 3, 2018

@SidharthBansal -- how was this looking, do you think it's something we could move ahead with? Thanks!!!

@SidharthBansal
Copy link
Member

There must be changes to this. I think @Ankit-Singla has quit as he has not replied in the other PRS by him from Feb. The other PR's issues were tackled later on by other contributors at public lab.

@SidharthBansal
Copy link
Member

Actually, my suggestion is to close this PR and look for other new comers to come and collaborate. If @Ankit-Singla would like to contribute he can reopen the PR.

@jywarren
Copy link
Member

jywarren commented Jun 3, 2018

That's fair -- we'd love your help @Ankit-Singla -- thanks! We're going to close this for now but please reach out if you're able to take it back up. It looks very promising, though!

Thanks again!

@jywarren jywarren closed this Jun 3, 2018
@jywarren jywarren mentioned this pull request Jun 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarpreet-chadha sagarpreet-chadha Awaiting requested review from sagarpreet-chadha

@namangupta01 namangupta01 Awaiting requested review from namangupta01

@ViditChitkara ViditChitkara Awaiting requested review from ViditChitkara

@SidharthBansal SidharthBansal Awaiting requested review from SidharthBansal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ankit-Singla @PublicLabBot @SidharthBansal @jywarren